Skip to content

릴리즈 발행시 동작하는 배포 워크플로우 생성 #654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
HowToBeAHappyBoy merged 8 commits into from
Jan 2, 2026
Merged

릴리즈 발행시 동작하는 배포 워크플로우 생성 #654

HowToBeAHappyBoy merged 8 commits into from
Jan 2, 2026

Conversation

@HowToBeAHappyBoy
Copy link
Contributor

@HowToBeAHappyBoy HowToBeAHappyBoy commented Dec 5, 2025 •
edited
Loading

변경 사항

  • 릴리즈 발행 → 빌드 → npm 배포 프로세스 자동화

목적

  • 릴리즈 발행시 NPM에 패키지 배포

테스트

리뷰어에게

  • 배포 전략에 맞게 잘 작성되었는지 확인 부탁드립니다

PR 작성자 체크 리스트

  • UI Review를 요청하고 검토를 받았나요?
  • UI Tests를 진행했나요?

@HowToBeAHappyBoy HowToBeAHappyBoy requested a review from a team as a code owner December 5, 2025 13:40
@HowToBeAHappyBoy HowToBeAHappyBoy linked an issue Dec 5, 2025 that may be closed by this pull request
배포 워크플로우 구현 #610
Closed
@HowToBeAHappyBoy HowToBeAHappyBoy force-pushed the 610-create-release-workflow branch from 842a750 to c403cdf Compare December 5, 2025 13:42
@DaleStudy DaleStudy deleted a comment from dalestudy bot Dec 5, 2025
@DaleSeo
Copy link
Member

DaleSeo commented Dec 12, 2025

@HowToBeAHappyBoy 님, 요거 계속 진척이 없네요? 병목이 될까봐 걱정이 됩니다. 업데이트 좀 부탁드릴께요!

@Lustellz
Copy link
Contributor

Lustellz commented Dec 12, 2025

@HowToBeAHappyBoy 님, 요거 계속 진척이 없네요? 병목이 될까봐 걱정이 됩니다. 업데이트 좀 부탁드릴께요!

제가 지금 좀 헷갈려서 그러는데 리뷰를 받아야 하는 상태이지 않나요?

@DaleSeo
Copy link
Member

DaleSeo commented Dec 12, 2025

제가 지금 좀 헷갈려서 그러는데 리뷰를 받아야 하는 상태이지 않나요?

@Lustellz 지난 회의 때, tag push 시점이 아닌 release published 시점에 워크플로우가 실행되도록 @hyoseong1994 님께서 프로세스 변경을 제안해주셨고, 그에 따라 @HowToBeAHappyBoy 님께서 본 PR에 반영해주시겠다고 한 걸로 기억하고 있습니다.

@HowToBeAHappyBoy HowToBeAHappyBoy changed the title 태그 생성시 동작하는 배포 워크플로우 생성 릴리즈 발행시 동작하는 배포 워크플로우 생성 Dec 18, 2025
@HowToBeAHappyBoy HowToBeAHappyBoy force-pushed the 610-create-release-workflow branch from 1bfc48b to 5675164 Compare December 18, 2025 12:48
github-advanced-security[bot]
github-advanced-security bot found potential problems Dec 18, 2025
View reviewed changes
hyoseong1994
hyoseong1994 reviewed Dec 18, 2025
View reviewed changes
@codecov
Copy link

codecov bot commented Dec 29, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@HowToBeAHappyBoy
Copy link
Contributor Author

HowToBeAHappyBoy commented Dec 29, 2025

@hyoseong1994 효성님 안녕하세요! 코멘트 주신 부분 반영하였으며, PR 본문에 테스트와 관련된 내용을 추가했습니다 확인 한 번만 부탁드립니다 감사합니다 🙇

@DaleSeo DaleSeo mentioned this pull request Dec 29, 2025
Closed
DaleSeo
DaleSeo reviewed Dec 29, 2025
View reviewed changes
Copy link
Member

@DaleSeo DaleSeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR 설명에 테스트 내용 공유해주셔서 리뷰하는데 큰 도움이 되었습니다!

hyoseong1994
hyoseong1994 approved these changes Dec 29, 2025
View reviewed changes
Copy link
Contributor

@hyoseong1994 hyoseong1994 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

리뷰하나 더 남겼는데 작업하였을 당시에는 없던 내역이라 우선 승인합니다. 작업 여부는 아카님이 판단하시고 알려주시면 후속 티켓 작성하는 등의 작업하도록하겠습니다

고생하셨습니다!

.github/workflows/release.yml Outdated
- name: Build package
run: |
bun run prepare
bun run build
Copy link
Contributor

@hyoseong1994 hyoseong1994 Dec 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

최근 작업한 내역에서 app 빌드와 lib 빌드과 나누어져 명령어가 bun run build:lib 로 변경되었습니다.

참고 PR입니다.
#685

Copy link
Contributor Author

@HowToBeAHappyBoy HowToBeAHappyBoy Jan 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

64c964c에서 반영되었습니다!

github-advanced-security[bot]
github-advanced-security bot found potential problems Jan 2, 2026
View reviewed changes
@HowToBeAHappyBoy
Copy link
Contributor Author

HowToBeAHappyBoy commented Jan 2, 2026

@DaleSeo 상세한 리뷰 감사합니다. 남겨주신 사항들은 64c964c에서 수정되었습니다
(PR 설명에 있는 데모 프로젝트에서 테스트 완료했습니다)
setup-node를 지우고 setup-bun만 남겼는데, registry-url을 설정해도 bunfig.toml이 토큰을 가지지 않은 채로 생성되어서 .npmrc를 생성하는 과정을 다시 추가했습니다

감사합니다!

DaleSeo
DaleSeo approved these changes Jan 2, 2026
View reviewed changes
Copy link
Member

@DaleSeo DaleSeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

피드백 반영해주셔서 감사합니다.

@DaleSeo DaleSeo mentioned this pull request Jan 2, 2026
Merged
2 tasks
@HowToBeAHappyBoy HowToBeAHappyBoy added this pull request to the merge queue Jan 2, 2026
Merged via the queue into main with commit 3b6cd9c Jan 2, 2026
10 checks passed
@HowToBeAHappyBoy HowToBeAHappyBoy deleted the 610-create-release-workflow branch January 2, 2026 08:27
This was referenced Jan 7, 2026
Closed
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DaleSeo DaleSeo DaleSeo approved these changes

@hyoseong1994 hyoseong1994 hyoseong1994 approved these changes

Assignees

@HowToBeAHappyBoy HowToBeAHappyBoy

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

배포 워크플로우 구현

5 participants

@HowToBeAHappyBoy @DaleSeo @Lustellz @hyoseong1994